Skip to content

deps: update the deprecation status of libcurl#30731

Merged
htuch merged 3 commits intoenvoyproxy:mainfrom
suniltheta:libcurl_deprecate
Nov 7, 2023
Merged

deps: update the deprecation status of libcurl#30731
htuch merged 3 commits intoenvoyproxy:mainfrom
suniltheta:libcurl_deprecate

Conversation

@suniltheta
Copy link
Copy Markdown
Contributor

@suniltheta suniltheta commented Nov 5, 2023

Commit Message: deps: update the deprecation status of libcurl
Additional Description:
Following the merge of #29880 and #30626 we can mark the curl usage as deprecated. Meanwhile bazel/repositories.bzl had stale info that OpenCensus tracer was still using libcurl.

We can continue to keep the Issue #11816 open until curl is removed entirely after the deprecation time (Probably for v1.31 release).

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

deps: update the deprecation status of libcurl
58e1a8c 
Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 5, 2023
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Nov 5, 2023

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @htuch

🐱

Caused by: #30731 was opened by suniltheta.

see: more, trace.

@htuch
Copy link
Copy Markdown
Member

htuch commented Nov 5, 2023

To fully understand the timeline, are we basically saying that when envoy.reloadable_features.use_libcurl_to_fetch_aws_credentials is removed, we'll remove the libcurl dep?

@suniltheta
Copy link
Copy Markdown
Contributor Author

suniltheta commented Nov 5, 2023

Yes, with removing envoy.reloadable_features.use_libcurl_to_fetch_aws_credentials we should remember to remove curl dependency and any other artifacts related to curl within Envoy. Now that the reloadable feature is going to be released with v1.29, hopefully before 1.31 we can get rid of the feature flag.

@htuch
Copy link
Copy Markdown
Member

htuch commented Nov 5, 2023

OK, can you be explicit on this timeline in the Bazel comments? E.g. link to your above GH post.

add the timeline for deprecation
ed77b02 
Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
@suniltheta
Copy link
Copy Markdown
Contributor Author

suniltheta commented Nov 5, 2023

Thanks @htuch for the help. Please let me know if the code comments is sufficient.

existing
4ffaae3 
Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
htuch
htuch approved these changes Nov 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 7, 2023
@htuch htuch merged commit dd05ef6 into envoyproxy:main Nov 7, 2023
@suniltheta suniltheta mentioned this pull request Nov 22, 2023
Merged
@suniltheta suniltheta mentioned this pull request Dec 7, 2023
Merged
@asedeno asedeno mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@htuch htuch htuch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@htuch htuch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suniltheta @htuch